Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix impression events on RelatedProducts #211

Merged
merged 1 commit into from Feb 6, 2020

Conversation

iaronaraujo
Copy link
Contributor

What is the purpose of this pull request?

productImpression event wasn't being sent for items on the RelatedProducts shelf. This PR fixes this.

How should this be manually tested?

Workspace
See the related products shelf then go on console, type pixelManagerEvents and check that a productImpression event was sent with the products seen.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 5, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Feb 5, 2020

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@iaronaraujo iaronaraujo merged commit bdd87eb into master Feb 6, 2020
@iaronaraujo iaronaraujo deleted the fix/related-products-impression branch February 6, 2020 13:20
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 6, 2020

Your PR has been merged! App is being published. 🚀
Version 1.35.2 → 1.35.3

After the publishing process has been completed (check #vtex-io-notifications) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.shelf@1.35.3

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants