This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
Fix: Tweaks layout section spacings #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-469--base.preview.vtex.app |
filipewl
approved these changes
Apr 8, 2022
saranicoly
approved these changes
Apr 8, 2022
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 8m PerformanceLighthouse report
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR fixes the spaces (padding/margin) on elements that use the
layout__sectionclass.How does it work?
We changed the spacings from margin to padding on #464 due to a problem with the
box-shadowon theproduct-card. At first glance, it was good, but it causes a regression with PDP due to margin collapse. So we just change the style frompadding-toptomargin-topagain and it works as expected.How to test it?
The elements with the layout__section class should look like the previews before the #464.
References
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Mastering_margin_collapsing
Checklist