Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantum Phase Estimation and Hadamard test discussion #14

Closed
vtomole opened this issue Jun 3, 2019 · 10 comments
Closed

Quantum Phase Estimation and Hadamard test discussion #14

vtomole opened this issue Jun 3, 2019 · 10 comments

Comments

@vtomole
Copy link
Owner

vtomole commented Jun 3, 2019

Post: https://vtomole.github.io/blog/2018/05/20/pea

@masaduzz1
Copy link

Hi, thanks for the nice post. In the example of the Hadamard test, the output expression of the CU applied on 2 qubits does not look correct.

@vtomole
Copy link
Owner Author

vtomole commented Jul 30, 2020

Which part are you talking about exactly? Is it

The Hadamard test solves: Given a Unitary ....

part? What's not correct about it?

@masaduzz1
Copy link

Hi, thanks for the reply. When CU applied on (|0>+|1>) x |1>, isn't the o/p be |0>|1> + |1>(U|1>) = |0>|1> + |1>|0>? I didn't carry the 1/sqrt(2) factor here.

@vtomole
Copy link
Owner Author

vtomole commented Jul 31, 2020

|0>|1> + |1>(U|1>) = |0>|1> + |1>|0>

You have U on the left side but not the right. Where did it go?

@masaduzz1
Copy link

masaduzz1 commented Jul 31, 2020 via email

@vtomole
Copy link
Owner Author

vtomole commented Jul 31, 2020

You wrote

|0>|1> + |1>(U|1>) = |0>|1> + |1>|0>

What is U here? Is it an arbitrary unitary or did you make it the X gate?

@masaduzz1
Copy link

masaduzz1 commented Jul 31, 2020 via email

@vtomole
Copy link
Owner Author

vtomole commented Aug 1, 2020

Ah okay. I see my mistake. Thanks for pointing this out. I'll post a fix soon.

@masaduzz1
Copy link

masaduzz1 commented Aug 1, 2020 via email

@vtomole
Copy link
Owner Author

vtomole commented Aug 6, 2020

@masaduzz1 Hey, i made the fixes. Can you check to make sure that it makes sense now? Also, i would like to send you $5 as a thank you for finding this. How should i go about this?

Repository owner locked and limited conversation to collaborators Jun 27, 2023
@vtomole vtomole converted this issue into discussion #49 Jun 27, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants