Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Package Manager support #58

Conversation

@curato-research
Copy link

curato-research commented Sep 18, 2019

I have been successfully added Acknowlist using SPM using this package.swift file.

1 thing though is that I'm not using the default localized strings, I'm not sure if they would work this way. But it might just solve #53.

let package = Package(
name: "AcknowList",
platforms: [
.iOS(.v8)

This comment has been minimized.

Copy link
@ApolloZhu

ApolloZhu Oct 4, 2019

AcknowList is written in Swift 5, requires iOS 8.0 or tvOS 9.0 and above, Xcode 10.2 and above.

Suggested change
.iOS(.v8)
.iOS(.v8), .tvOS(.v9)
@vtourraine vtourraine merged commit 0919d38 into vtourraine:master Oct 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vtourraine vtourraine changed the title ref #53 - add package .swift Add Swift Package Manager support Oct 7, 2019
@vtourraine

This comment has been minimized.

Copy link
Owner

vtourraine commented Oct 7, 2019

Alright!

Sorry it took so long, but I’ve finally merged this in, and tagged it as a new release (1.9.2), so you can now install AcknowList with SPM from Xcode. 🎉

But we still have a couple of issues with SPM:

  1. No resources for localization: as far as I know, we can’t include a Bundle for the localization strings, and we’re waiting for an official SPM solution. Dedicated issue: #59
  2. Repo folders: this repo doesn’t use the default SPM folders structure (Sources, etc). We can still make it work with the path configuration, but the resulting package includes a lot of unnecessary files. Maybe we should take that opportunity to switch to the default SPM structure, and bump this library version number to AcknowList 2.0. Dedicated issue: #60
  3. Unit test: this is related to the files structure, I think, because if I try to define the test target in Package.swift, the package can’t run properly. If I re-organize the folders with the default structure, the tests run as expected (and mostly fail, because the resources are missing). Dedicated issue: #61

I’ve created GitHub issues for each of these problems. I really don’t have a lot of experience with SPM, so feel free to suggest better solutions for these challenges. Thanks!

@vtourraine

This comment has been minimized.

Copy link
Owner

vtourraine commented Oct 7, 2019

(updated with GitHub issues references)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.