Fix mobile browser detection for Rainbow mobile wallet #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
isMobileAppBrowsercould not be detected as true in the Rainbow embedded browser, causing it to connect to rdns.The unique aspect of the Rainbow mobile wallet is that it has both an eip6963 provider and
window.ethereum.Solution
Corrected and renamed as
isMobileBrowser.Other considerations
Originally, the intention was to change the strategy to prioritize EIP6963, then fallback to fetching
window.ethereum, and finally remove the mobile browser detection mechanism.However, this approach encountered a roadblock: when a desktop browser disconnects the sole EIP6963 provider and reloads the page, it automatically reconnects to that provider.
As a result, this strategy was abandoned in favor of continuing to use the mobile browser detection mechanism:
If
auto-connectis disabled, clicking "connect" in any mobile browser will directly connect towindow.ethereum(if available).If
auto-connectis enabled, any mobile browser will automatically connect towindow.ethereumupon page load (if available).