-
-
Notifications
You must be signed in to change notification settings - Fork 32
Add labelComponents option to form control has label #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vhoyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, but i don't see tests for this feature on the diff, could you add them?
Another thing, I think we will need to ask the maintainer about this, but I think you don't need to update te version on this PR 🤔
Ah I missed the tests folder! Updated. |
vhoyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, wdyt @kddnewton ?
|
Any update on this? Still throwing warnings all over the shop in our app. |
|
Fixed the conflicts, reckon this can get merged in? |
|
Nice addition 👍🏼 Would be great to see this added 🙏 |
We have custom label components in our app which means the
form-control-has-labelrule is always triggered.I've leant on the options setup for
label-has-forand implemented a similar setup where you can pass an array of custom components to be considered aslabelelements by the rule for validation.In the app template:
Pass the label components as part of the ruleset: