Skip to content

Modal is closing when I select text with mousedown inside and mouseup outside modal #111

Description

@mankey-ru

Version

vue-final-modal: 2.3.1
vue: 2.6.12

OS

Windows

Reproduction Link

https://codesandbox.io/s/cocky-night-0ysyb?file=/src/App.vue

Steps to reproduce

Select the text with a sloppy move: mousedown is inside the modal and mouse button released when cursor is on overlay

What is Expected?

Text is selected and modal is not closed

What is actually happening?

modal closed. Probably event type should be mousedown OR event handler should check Window.getSelection()

Activity

  1. hunterliu1003 commented on Jun 5, 2021

    @hunterliu1003
    Member

    Hi @mankey-ru,

    Thank you for providing good reproduction. I will study if there is any good solution.

  2. added 3 commits that reference this issue on Jun 11, 2021
    1d47ff6
    f15022a
    090d854
  3. hunterliu1003 commented on Jun 12, 2021

    @hunterliu1003
    Member

    The bugfix will be released in

    v2.3.2 for Vue 2
    v3.3.1 for Vue3

  4. added a commit that references this issue on Jun 13, 2021
    52ddf45
  5. hunterliu1003 commented on Jun 13, 2021

    @hunterliu1003
    Member

    The bugfix was released in

    v2.3.2 for Vue 2
    v3.3.1 for Vue3

  6. added a commit that references this issue on Jun 24, 2021
    0c728ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions