Merged
Conversation
|
|
🦋 Changeset detectedLatest commit: f14b196 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vercel
bot
temporarily deployed
to
Preview – unplugin-vue-macros-coverage
sxzz
reviewed
Mar 22, 2023
Member
sxzz
left a comment
sxzz
left a comment
There was a problem hiding this comment.
Hey, thanks for your contribution!
However I think it could be better to make two macros into one page called singleDefine.
vercel
bot
temporarily deployed
to
Preview – unplugin-vue-macros-coverage
Contributor
Author
Done! |
sxzz
force-pushed
the
feat-single-define-docs
branch
from
813ee64 to
bf78940
Compare
vercel
bot
temporarily deployed
to
Preview – unplugin-vue-macros-coverage
sxzz
approved these changes
Mar 22, 2023
vercel
bot
temporarily deployed
to
Preview – unplugin-vue-macros-coverage
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will add
@vue-macro/single-defineusage docs.And also some missing single-define ts types in
unplugin-vue-macrospackageLinked Issues
#295
Additional context
I forgot to add the types reference of the package in packages/macros/macros-global.d.ts, so I add in this PR.