New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack3 is coming #751

Closed
cccRaim opened this Issue Jun 20, 2017 · 27 comments

Comments

Projects
None yet
10 participants
@cccRaim

cccRaim commented Jun 20, 2017

so when upgrade?

@MaxMilton

This comment has been minimized.

Show comment
Hide comment
@MaxMilton

MaxMilton Jun 20, 2017

I played with it a little bit and had problems with webpack-hot-middleware not doing hot updates correctly but rather reloading the whole page. Other than that things worked as expected, however, I didn't do any in-depth testing.

MaxMilton commented Jun 20, 2017

I played with it a little bit and had problems with webpack-hot-middleware not doing hot updates correctly but rather reloading the whole page. Other than that things worked as expected, however, I didn't do any in-depth testing.

@PanJiaChen

This comment has been minimized.

Show comment
Hide comment
@PanJiaChen

PanJiaChen Jun 21, 2017

Contributor

@MaxMilton same problem
l remove

// compiler.plugin('compilation', function (compilation) {
//     compilation.plugin('html-webpack-plugin-after-emit', function (data, cb) {
//         hotMiddleware.publish({action: 'reload'});
//         cb()
//     })
// });

now hot updates is ok

Contributor

PanJiaChen commented Jun 21, 2017

@MaxMilton same problem
l remove

// compiler.plugin('compilation', function (compilation) {
//     compilation.plugin('html-webpack-plugin-after-emit', function (data, cb) {
//         hotMiddleware.publish({action: 'reload'});
//         cb()
//     })
// });

now hot updates is ok

@limichange

This comment has been minimized.

Show comment
Hide comment
@limichange

limichange Jun 21, 2017

Contributor

How to fix this warning 🤔

⠧ building for production...(node:91029) DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.
Contributor

limichange commented Jun 21, 2017

How to fix this warning 🤔

⠧ building for production...(node:91029) DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.
@LinusBorg

This comment has been minimized.

Show comment
Hide comment
@LinusBorg

LinusBorg Jun 21, 2017

Contributor

There's still some plugins that we rely on that have to release compatible versions (`` extract-text-webpack-plugin and html-webpack-plugin among them) so we will wait for those issue to resolve before we make the jump.

Contributor

LinusBorg commented Jun 21, 2017

There's still some plugins that we rely on that have to release compatible versions (`` extract-text-webpack-plugin and html-webpack-plugin among them) so we will wait for those issue to resolve before we make the jump.

@sudo-suhas

This comment has been minimized.

Show comment
Hide comment
@sudo-suhas

sudo-suhas Jul 16, 2017

Contributor

@LinusBorg extract-text-webpack-plugin and html-webpack-plugin have been updated to support webpack 3. inject-loader has still not been updated though.

Contributor

sudo-suhas commented Jul 16, 2017

@LinusBorg extract-text-webpack-plugin and html-webpack-plugin have been updated to support webpack 3. inject-loader has still not been updated though.

@LinusBorg

This comment has been minimized.

Show comment
Hide comment
@LinusBorg

LinusBorg Jul 16, 2017

Contributor

Do you know what issues exist with inject-loader with webpack 3?

Contributor

LinusBorg commented Jul 16, 2017

Do you know what issues exist with inject-loader with webpack 3?

@sudo-suhas

This comment has been minimized.

Show comment
Hide comment
@sudo-suhas

sudo-suhas Jul 16, 2017

Contributor

There was a PR merged in which allowed webpack 3 peer dependency. But not released.

Contributor

sudo-suhas commented Jul 16, 2017

There was a PR merged in which allowed webpack 3 peer dependency. But not released.

@sudo-suhas

This comment has been minimized.

Show comment
Hide comment
@sudo-suhas

sudo-suhas Jul 16, 2017

Contributor

@limichange I think this warning was coming from extract-text-webpack-plugin.

DeprecationWarning: Chunk.modules is deprecated.

Looks to be fixed - extract-text-webpack-plugin/CHANGELOG.md#breaking-changes

Contributor

sudo-suhas commented Jul 16, 2017

@limichange I think this warning was coming from extract-text-webpack-plugin.

DeprecationWarning: Chunk.modules is deprecated.

Looks to be fixed - extract-text-webpack-plugin/CHANGELOG.md#breaking-changes

@limichange

This comment has been minimized.

Show comment
Hide comment
@limichange
Contributor

limichange commented Jul 16, 2017

@MaxMilton

This comment has been minimized.

Show comment
Hide comment
@MaxMilton

MaxMilton Jul 27, 2017

I've opened an issue with inject-loader: plasticine/inject-loader#46

I believe this is the last package now which needs updating before we can work on our own webpack 3 compatibility.

MaxMilton commented Jul 27, 2017

I've opened an issue with inject-loader: plasticine/inject-loader#46

I believe this is the last package now which needs updating before we can work on our own webpack 3 compatibility.

This was referenced Jul 27, 2017

@MaxMilton

This comment has been minimized.

Show comment
Hide comment
@MaxMilton

MaxMilton Jul 27, 2017

Update: inject-loader 3.0.1 is now published with webpack 3 compatibility.

MaxMilton commented Jul 27, 2017

Update: inject-loader 3.0.1 is now published with webpack 3 compatibility.

@LinusBorg

This comment has been minimized.

Show comment
Hide comment
@LinusBorg

LinusBorg Jul 27, 2017

Contributor

Thanks for the heads-up! I guess we should be looking to upgrading this template now.

Contributor

LinusBorg commented Jul 27, 2017

Thanks for the heads-up! I guess we should be looking to upgrading this template now.

@adam-lynch

This comment has been minimized.

Show comment
Hide comment
@adam-lynch

adam-lynch Aug 1, 2017

Contributor

This still doesn't work from me. Am I missing something?

I've:

  • extract-text-webpack-plugin@3.0.0
  • html-webpack-plugin@2.30.1
  • http-proxy-middleware@0.17.3
  • inject-loader@3.0.1
  • webpack-dev-middleware@1.12.0
  • webpack-hot-middleware@2.18.2
  • webpack@3.4.1

I assume I shouldn't actually do #751 (comment) because it'll break other stuff.

cc @sudo-suhas @LinusBorg

Contributor

adam-lynch commented Aug 1, 2017

This still doesn't work from me. Am I missing something?

I've:

  • extract-text-webpack-plugin@3.0.0
  • html-webpack-plugin@2.30.1
  • http-proxy-middleware@0.17.3
  • inject-loader@3.0.1
  • webpack-dev-middleware@1.12.0
  • webpack-hot-middleware@2.18.2
  • webpack@3.4.1

I assume I shouldn't actually do #751 (comment) because it'll break other stuff.

cc @sudo-suhas @LinusBorg

@LeeBelieve

This comment has been minimized.

Show comment
Hide comment
@LeeBelieve

LeeBelieve Aug 2, 2017

+1 still have HMR failed problem with the same versions

LeeBelieve commented Aug 2, 2017

+1 still have HMR failed problem with the same versions

@sudo-suhas

This comment has been minimized.

Show comment
Hide comment
@sudo-suhas

sudo-suhas Aug 2, 2017

Contributor

@adam-lynch I don't think it is as simple as updating all the package dependency versions. While webpack@3 was a backward compatible release for the most part, there are evidently differences in behavior which are breaking the hot reload. Let's wait for the repo maintainers to update.

Contributor

sudo-suhas commented Aug 2, 2017

@adam-lynch I don't think it is as simple as updating all the package dependency versions. While webpack@3 was a backward compatible release for the most part, there are evidently differences in behavior which are breaking the hot reload. Let's wait for the repo maintainers to update.

@MaxMilton

This comment has been minimized.

Show comment
Hide comment
@MaxMilton

MaxMilton Aug 2, 2017

@adam-lynch you might have issues with webpack-dev-middleware: ^1.12.0, in my projects I'm keeping it at version 1.11.0 ; "webpack-dev-middleware": "~1.11.0"

This template doesn't have official support for webpack 3 yet so you can't expect it to magically work if you just upgrade all the packages. You can upgrade all packages (other than webpack-dev-middleware) and use the workaround in #751 (comment) but understand this will make HMR work at the cost of reduced functionality (no page reload when the html-webpack-plugin template changes).

MaxMilton commented Aug 2, 2017

@adam-lynch you might have issues with webpack-dev-middleware: ^1.12.0, in my projects I'm keeping it at version 1.11.0 ; "webpack-dev-middleware": "~1.11.0"

This template doesn't have official support for webpack 3 yet so you can't expect it to magically work if you just upgrade all the packages. You can upgrade all packages (other than webpack-dev-middleware) and use the workaround in #751 (comment) but understand this will make HMR work at the cost of reduced functionality (no page reload when the html-webpack-plugin template changes).

@yoyo837

This comment has been minimized.

Show comment
Hide comment
@yoyo837

yoyo837 Aug 8, 2017

Concern this all the time. Waiting for good news!

yoyo837 commented Aug 8, 2017

Concern this all the time. Waiting for good news!

c0defre4k pushed a commit to neonblack-at/webpack that referenced this issue Aug 9, 2017

@adam-lynch

This comment has been minimized.

Show comment
Hide comment
@adam-lynch

adam-lynch Aug 15, 2017

Contributor

Does this change anything? Stabilizing webpack 3 (week 18–19)

Contributor

adam-lynch commented Aug 15, 2017

Does this change anything? Stabilizing webpack 3 (week 18–19)

@LinusBorg

This comment has been minimized.

Show comment
Hide comment
@LinusBorg

LinusBorg Aug 28, 2017

Contributor

So I was looking into this again, and it seems that there is a general problem with that html-webpack-plugin:

jantimon/html-webpack-plugin#680

So think we should implement the workaround of #751 (comment) in our template until the problem for that pluign has been resolved by its maintainers.

Contributor

LinusBorg commented Aug 28, 2017

So I was looking into this again, and it seems that there is a general problem with that html-webpack-plugin:

jantimon/html-webpack-plugin#680

So think we should implement the workaround of #751 (comment) in our template until the problem for that pluign has been resolved by its maintainers.

@adam-lynch

This comment has been minimized.

Show comment
Hide comment
@adam-lynch

adam-lynch Aug 28, 2017

Contributor

@LinusBorg what are the downsides to that exactly? That if you edit index.html (at the root of your project), your app won't reload?

Contributor

adam-lynch commented Aug 28, 2017

@LinusBorg what are the downsides to that exactly? That if you edit index.html (at the root of your project), your app won't reload?

@LinusBorg

This comment has been minimized.

Show comment
Hide comment
@LinusBorg

LinusBorg Aug 28, 2017

Contributor

yep, that's all, pretty much.

Contributor

LinusBorg commented Aug 28, 2017

yep, that's all, pretty much.

@LinusBorg

This comment has been minimized.

Show comment
Hide comment
@LinusBorg

LinusBorg Sep 1, 2017

Contributor

I just submitted a PR for webpack 3 here, you can easily check it out with

vue init webpack#webpack_3

It would be great if a few folks could take this for a quick spin and report that everything is working for them.

Contributor

LinusBorg commented Sep 1, 2017

I just submitted a PR for webpack 3 here, you can easily check it out with

vue init webpack#webpack_3

It would be great if a few folks could take this for a quick spin and report that everything is working for them.

@txchen

This comment has been minimized.

Show comment
Hide comment
@txchen

txchen Oct 7, 2017

When I run vue init webpack#webpack_3, I got Failed to download repo vuejs-templates/webpack#webpack_3: Response code 404 (Not Found)

How should I fix this, please?

txchen commented Oct 7, 2017

When I run vue init webpack#webpack_3, I got Failed to download repo vuejs-templates/webpack#webpack_3: Response code 404 (Not Found)

How should I fix this, please?

@sudo-suhas

This comment has been minimized.

Show comment
Hide comment
@sudo-suhas

sudo-suhas Oct 7, 2017

Contributor

The branch has been merged.. No need to specify the branch

Contributor

sudo-suhas commented Oct 7, 2017

The branch has been merged.. No need to specify the branch

@txchen

This comment has been minimized.

Show comment
Hide comment
@txchen

txchen Oct 7, 2017

@sudo-suhas but my newly generated project still has "webpack": "^2.6.1"?

txchen commented Oct 7, 2017

@sudo-suhas but my newly generated project still has "webpack": "^2.6.1"?

@sudo-suhas

This comment has been minimized.

Show comment
Hide comment
@sudo-suhas

sudo-suhas Oct 7, 2017

Contributor

My bad. Try vue init webpack#develop

Contributor

sudo-suhas commented Oct 7, 2017

My bad. Try vue init webpack#develop

@adam-lynch

This comment has been minimized.

Show comment
Hide comment
@adam-lynch

adam-lynch Nov 1, 2017

Contributor

I've been keeping an eye on this issue but it might not receive any more comments so I hope you don't mind but I created #1022 to track when the hot reloading of the root html file will work again.

Contributor

adam-lynch commented Nov 1, 2017

I've been keeping an eye on this issue but it might not receive any more comments so I hope you don't mind but I created #1022 to track when the hot reloading of the root html file will work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment