New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowBlank option #51

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@nholden

nholden commented Feb 15, 2018

Adds a new option that, when set to true, allows v-money fields to be initialized blank or cleared out by the user. The option is false by default, so it should not impact existing v-money fields.

Addresses #28

Add allowBlank option
Adds a new option that, when set to true, allows v-money fields to be
initialized blank or cleared out by the user. The option is false by
default, so it should not impact existing v-money fields.

Addresses #28
@gfviegas

This comment has been minimized.

gfviegas commented Feb 15, 2018

This is a must!!!

@gfviegas

Great work, I've made a fork with similar changes but this approach is cleaner and way better to mantain since it's backward compatible.

@nholden

This comment has been minimized.

nholden commented Feb 15, 2018

Thanks, @gfviegas! I'm referencing my fork at https://github.com/nholden/v-money in a project right now, but it would be great to see this or something similar included in a future release.

@remkobrenters

This comment has been minimized.

remkobrenters commented Mar 21, 2018

Please accept this PR

2 similar comments
@chiaretto

This comment has been minimized.

chiaretto commented Mar 31, 2018

Please accept this PR

@paulpv

This comment has been minimized.

paulpv commented Apr 3, 2018

Please accept this PR

@DinsmoreDesign

This comment has been minimized.

DinsmoreDesign commented May 7, 2018

Looks like this was added way back in February, but still no merge :(

Is there a way to pull your version in through NPM, so I can use it, instead...?

@nholden

This comment has been minimized.

nholden commented May 7, 2018

I'm using Yarn, so I ran the following to add my fork to a project.

yarn add nholden/v-money

Looks like that would also work for NPM, although I haven't tried it.

npm install nholden/v-money
@DinsmoreDesign

This comment has been minimized.

DinsmoreDesign commented May 7, 2018

@nholden Ah dang, I didn't notice your implementation is only on the directive. Any plans to add it to the component version, as well?

@nholden

This comment has been minimized.

nholden commented May 7, 2018

@DinsmoreDesign Seems like it wouldn't be too tricky. Let me take a closer look this evening and get back to you.

@nholden

This comment has been minimized.

nholden commented May 8, 2018

@DinsmoreDesign I just updated this PR as well as my fork to add the allowBlank option to the <money> component. Here's a demo.

@DinsmoreDesign

This comment has been minimized.

DinsmoreDesign commented May 8, 2018

@nholden Awesome! I was going to tinker with it and submit a pull request to your pull request, but that seemed like a lot of pull requests :P

@Simsteve7

This comment has been minimized.

Simsteve7 commented May 15, 2018

Really would like this pr merged 😄

@breaktag

This comment has been minimized.

breaktag commented Jul 20, 2018

Please accept this PR

@nholden

This comment has been minimized.

nholden commented Jul 20, 2018

Hey, everybody!

Thanks for sharing that this PR is still relevant for you. To reduce the noise for everyone subscribed to this PR: if you'd like to voice your support for this moving forward, please give a 👍 to the original post.

If you need this functionality now, please see this comment on how to use my fork.

And, of course, if you have other feedback, feel free to comment.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment