Skip to content
Permalink
Browse files
fix(reactivity-transform): should not rewrite catch param (#5711)
fix #5709
  • Loading branch information
edison1105 committed Apr 14, 2022
1 parent 86858a9 commit 1f14f194396bf9296a1046d3f680d6d318cd0e40
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 0 deletions.
@@ -216,6 +216,11 @@ exports[`should not rewrite scope variable 1`] = `
console.log(d.value)
console.log(e)
}
let err = _ref(null)
try {
} catch (err) {
console.log(err)
}
"
`;
@@ -222,12 +222,18 @@ test('should not rewrite scope variable', () => {
console.log(d)
console.log(e)
}
let err = $ref(null)
try {
} catch (err) {
console.log(err)
}
`)
expect(code).toMatch('console.log(a)')
expect(code).toMatch('console.log(b.value)')
expect(code).toMatch('console.log(c)')
expect(code).toMatch('console.log(d.value)')
expect(code).toMatch('console.log(e)')
expect(code).toMatch('console.log(err)')
assertCode(code)
})

@@ -566,6 +566,16 @@ export function transformAST(
return
}

// catch param
if (node.type === 'CatchClause') {
scopeStack.push((currentScope = {}))
if (node.param && node.param.type === 'Identifier') {
registerBinding(node.param)
}
walkScope(node.body)
return
}

// non-function block scopes
if (node.type === 'BlockStatement' && !isFunctionType(parent!)) {
scopeStack.push((currentScope = {}))

0 comments on commit 1f14f19

Please sign in to comment.