Skip to content
Permalink
Browse files
fix(runtime-core/template-ref): named ref in v-for regression fix (#5118
)

close #5116
close #5447
close #5525
  • Loading branch information
lidlanca committed Apr 12, 2022
1 parent 7efb9db commit cee1eafb4d2d5df901c9536ac59c321be72598b5
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 0 deletions.
@@ -442,4 +442,59 @@ describe('api: template refs', () => {
await nextTick()
expect(mapRefs()).toMatchObject(['2', '3', '4'])
})



test('named ref in v-for', async () => {
const show = ref(true);
const list = reactive([1, 2, 3])
const listRefs = ref([])
const mapRefs = () => listRefs.value.map(n => serializeInner(n))

const App = {
setup() {
return { listRefs }
},
render() {
return show.value
? h(
'ul',
list.map(i =>
h(
'li',
{
ref: 'listRefs',
ref_for: true
},
i
)
)
)
: null
}
}
const root = nodeOps.createElement('div')
render(h(App), root)

expect(mapRefs()).toMatchObject(['1', '2', '3'])

list.push(4)
await nextTick()
expect(mapRefs()).toMatchObject(['1', '2', '3', '4'])

list.shift()
await nextTick()
expect(mapRefs()).toMatchObject(['2', '3', '4'])

show.value = !show.value
await nextTick()

expect(mapRefs()).toMatchObject([])

show.value = !show.value
await nextTick()
expect(mapRefs()).toMatchObject(['2', '3', '4'])
})


})
@@ -91,6 +91,9 @@ export function setRef(
if (!isArray(existing)) {
if (_isString) {
refs[ref] = [refValue]
if (hasOwn(setupState, ref)) {
setupState[ref] = refs[ref]
}
} else {
ref.value = [refValue]
if (rawRef.k) refs[rawRef.k] = ref.value

0 comments on commit cee1eaf

Please sign in to comment.