Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity-transform): don't overwrite scope and user imports #6840

Merged
merged 1 commit into from
Nov 9, 2022
Merged

fix(reactivity-transform): don't overwrite scope and user imports #6840

merged 1 commit into from
Nov 9, 2022

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Oct 9, 2022

closes #6838


Fixed cases:

Comment on lines +156 to +162
// default symbol
if (!convertSymbol && !userImports[CONVERT_SYMBOL]) {
convertSymbol = CONVERT_SYMBOL
}
if (!escapeSymbol && !userImports[ESCAPE_SYMBOL]) {
escapeSymbol = ESCAPE_SYMBOL
}
Copy link
Member Author

@sxzz sxzz Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some opinions about the RFC: vuejs/rfcs#369 (comment)

@yyx990803 yyx990803 merged commit 7663a79 into vuejs:main Nov 9, 2022
@sxzz sxzz deleted the fix/reactivity-transform-existing-variable branch November 9, 2022 01:33
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When enable reactivityTransform $ can only be used as the initializer of a variable declaration. appears
3 participants