Skip to content

Conversation

@edison1105
Copy link
Member

close #12906

}
// .foo * -> .foo[xxxxxxx] *
if (node) return
// .foo * -> .foo *[xxxxxxx]
Copy link
Member Author

@edison1105 edison1105 Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38.1 kB 34.3 kB
vue.global.prod.js 158 kB 58 kB 51.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB 16.7 kB
createApp 54.6 kB 21.3 kB 19.4 kB
createSSRApp 58.8 kB 23 kB 21 kB
defineCustomElement 59.4 kB 22.9 kB 20.8 kB
overall 68.6 kB 26.4 kB 24 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 19, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12908

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12908

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12908

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12908

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12908

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12908

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12908

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12908

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12908

vue

npm i https://pkg.pr.new/vue@12908

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12908

commit: 547b870

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: sfc 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Feb 19, 2025
@thecodewarrior
Copy link
Contributor

This will cause a regression of #10548. To avoid the regression, the selector should have the scope tag on both the last class and the universal selector. I implemented a fix that does that, including an expanded test suite. I can create a PR if it looks alright.

@edison1105
Copy link
Member Author

@thecodewarrior
uh~, I overlooked that. Thanks for the motion. Your fix looks good, Please open a PR and I am closing this one.

@edison1105 edison1105 closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: sfc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Star selectors leak scoped styles into children

3 participants