-
-
Notifications
You must be signed in to change notification settings - Fork 9k
chore(runtime-vapor): render fallback at the deepest invalid fragment #14172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ng and improve invalid fragment detection.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the fragment fallback processing logic to prevent duplicate processing and improve invalid fragment detection through a more explicit, callback-based approach.
Key Changes:
- Introduces a
processedFallbacksWeakMap to track which fallbacks have been applied to fragments, preventing redundant chaining when the same fallback is reused - Replaces the
findInvalidFragmentrecursive function with inline detection using a callback pattern that identifies the deepest invalid fragment during fallback traversal - Adds an optional
onFragmentcallback parameter tosetFragmentFallbackto enable side effects during fragment tree traversal
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.