Skip to content

Conversation

@edison1105
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 5, 2025 09:40
@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/refactor/Fallback

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.5 kB 36.5 kB
vue.global.prod.js 166 kB 60.5 kB 53.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.2 kB 18.8 kB 17.2 kB
createApp 57.2 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 95.9 kB (-4 B) 35.4 kB (+6 B) 32 kB (+34 B)
createVaporApp 40.9 kB (-4 B) 15.2 kB (+13 B) 13.8 kB (+17 B)
createSSRApp 61.6 kB 23.8 kB 21.7 kB
defineCustomElement 63.3 kB 23.8 kB 21.7 kB
overall 71.9 kB 27.2 kB 24.8 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 5, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14172

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14172

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14172

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14172

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14172

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14172

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14172

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14172

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14172

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14172

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14172

vue

npm i https://pkg.pr.new/vue@14172

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14172

commit: 6b8693d

@edison1105 edison1105 added the scope: vapor related to vapor mode label Dec 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the fragment fallback processing logic to prevent duplicate processing and improve invalid fragment detection through a more explicit, callback-based approach.

Key Changes:

  • Introduces a processedFallbacks WeakMap to track which fallbacks have been applied to fragments, preventing redundant chaining when the same fallback is reused
  • Replaces the findInvalidFragment recursive function with inline detection using a callback pattern that identifies the deepest invalid fragment during fallback traversal
  • Adds an optional onFragment callback parameter to setFragmentFallback to enable side effects during fragment tree traversal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105 edison1105 changed the title refactor(runtime-vapor): prevent duplicate fragment fallback processing and improve invalid fragment detection. chore(runtime-vapor): render fallback at the deepest invalid fragment Dec 5, 2025
@edison1105 edison1105 merged commit e499d56 into minor Dec 5, 2025
17 checks passed
@edison1105 edison1105 deleted the edison/refactor/Fallback branch December 5, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants