Skip to content

fix(runtime-core): correctly propagate placeholder for async component #14177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rzzf wants to merge 2 commits into from
+74 −1
Closed

fix(runtime-core): correctly propagate placeholder for async component #14177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea03d8e
fix(runtime-core): correctly propagate placeholder for async component
rzzf Dec 6, 2025
ac75959
fix: update
rzzf Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions packages/runtime-core/__tests__/components/Suspense.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2395,4 +2395,67 @@ describe('Suspense', () => {
expect(unmounted).toHaveBeenCalledTimes(1)
})
})

// #14173
test('renders multiple async components in Suspense with v-for and updates list order with HOC', async () => {
const CompAsyncSetup = defineAsyncComponent({
props: ['item'],
render(ctx: any) {
return h('div', ctx.item.name)
},
})

const CompWrapper = {
props: ['item'],
render(ctx: any) {
return h(CompAsyncSetup, { item: ctx.item })
},
}

const items = ref([
{ id: 1, name: '111' },
{ id: 2, name: '222' },
{ id: 3, name: '333' },
])

const Comp = {
setup() {
return () =>
h(Suspense, null, {
default: () =>
h('div', [
h(
Fragment,
null,
items.value.map(item =>
h(CompWrapper, { item, key: item.id }),
),
),
]),
})
},
}

const root = nodeOps.createElement('div')
render(h(Comp), root)

await nextTick()
await Promise.all(deps)

expect(serializeInner(root)).toBe(
`<div><div>111</div><div>222</div><div>333</div></div>`,
)

items.value = [
{ id: 4, name: '444' },
{ id: 5, name: '555' },
{ id: 6, name: '666' },
]

await nextTick()
await Promise.all(deps)
expect(serializeInner(root)).toBe(
`<div><div>444</div><div>555</div><div>666</div></div>`,
)
})
})
12 changes: 11 additions & 1 deletion packages/runtime-core/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1996,7 +1996,9 @@ function baseCreateRenderer(
const anchor =
nextIndex + 1 < l2
? // #13559, fallback to el placeholder for unresolved async component
anchorVNode.el || anchorVNode.placeholder
anchorVNode.el ||
anchorVNode.placeholder ||
getSubTreeElement(anchorVNode)
: parentAnchor
if (newIndexToOldIndexMap[i] === 0) {
// mount new
Expand Down Expand Up @@ -2418,6 +2420,14 @@ function baseCreateRenderer(
)
}

const getSubTreeElement = (vnode: VNode): RendererNode | null => {
let current = vnode
while (current.component) {
current = current.component.subTree
}
return current.el || current.placeholder
Copy link
Member

@edison1105 edison1105 Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to get current.el here; if el has a value, then anchorVNode.el must also have a value.
Just need to get current.placeholder.

This implementation isn't quite right either; we shouldn't keep searching down the subTree but should early return as soon as we find the placeholder.

Copy link
Member

@edison1105 edison1105 Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but I perfer https://github.com/vuejs/core/pull/14182/files

}

return {
render,
hydrate,
Expand Down
Loading