Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): missing structure info for compiler-sfc #3559

Merged
merged 1 commit into from Jan 17, 2022
Merged

docs(contributing): missing structure info for compiler-sfc #3559

merged 1 commit into from Jan 17, 2022

Conversation

JayFate
Copy link
Contributor

@JayFate JayFate commented Apr 7, 2021

Signed-off-by: pengjie 37610029@qq.com

Signed-off-by: pengjie <37610029@qq.com>
@JayFate
Copy link
Contributor Author

JayFate commented May 28, 2021

@tjk Do you have a minute to review this pull request ?

@tjk
Copy link
Contributor

tjk commented May 28, 2021

Seems fine great to me, but I'm not really qualified to review it. Maybe try to get someone's attention in the Vue discord? I'm not sure which channel is best unfortunately...

@JayFate
Copy link
Contributor Author

JayFate commented May 29, 2021

Seems fine great to me, but I'm not really qualified to review it. Maybe try to get someone's attention in the Vue discord? I'm not sure which channel is best unfortunately...

Got it~

@JayFate
Copy link
Contributor Author

JayFate commented May 29, 2021

@HcySunYang Do you have a minute to review this pull request ?

@JayFate
Copy link
Contributor Author

JayFate commented Jan 17, 2022

@yyx990803 Do you have a minute to review the PR?

@yyx990803 yyx990803 merged commit 8cbfe09 into vuejs:master Jan 17, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants