From 751efca51614398477150b81413a638d2e2ba13a Mon Sep 17 00:00:00 2001 From: HcySunYang Date: Fri, 9 Apr 2021 17:06:29 +0800 Subject: [PATCH] fix(runtime-dom): capture errors when setting value for IDL --- packages/runtime-dom/__tests__/patchProps.spec.ts | 8 ++++++++ packages/runtime-dom/src/modules/props.ts | 5 ++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/runtime-dom/__tests__/patchProps.spec.ts b/packages/runtime-dom/__tests__/patchProps.spec.ts index bec0f9ba342..9df04078e6d 100644 --- a/packages/runtime-dom/__tests__/patchProps.spec.ts +++ b/packages/runtime-dom/__tests__/patchProps.spec.ts @@ -156,4 +156,12 @@ describe('runtime-dom: props patching', () => { // see https://github.com/vuejs/vue-next/issues/2766 patchProp(el, 'type', 'text', null) }) + + test('input with size', () => { + const el = document.createElement('input') + patchProp(el, 'size', null, 100) + expect(el.size).toBe(100) + patchProp(el, 'size', 100, null) + expect(el.getAttribute('size')).toBe(null) + }) }) diff --git a/packages/runtime-dom/src/modules/props.ts b/packages/runtime-dom/src/modules/props.ts index 068701642f8..ec8a9dda752 100644 --- a/packages/runtime-dom/src/modules/props.ts +++ b/packages/runtime-dom/src/modules/props.ts @@ -49,7 +49,10 @@ export function patchDOMProp( return } else if (type === 'number') { // e.g. - el[key] = 0 + // the value of some IDL attr must be greater than 0, e.g. input.size = 0 -> error + try { + el[key] = 0 + } catch {} el.removeAttribute(key) return }