Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): do not treat non-existent property as available #4962

wants to merge 1 commit into from


Copy link

@xanf xanf commented Nov 18, 2021

PublicComponentInstance was treating any property as available (has will return true) due to caching it inside accessCache with flag 4 (OTHER). This flag is unused across entire codebase, so my naive approach is to remove it

PublicComponentInstance should not consider property as available
on instance if it was accessed but was not found
@yyx990803 yyx990803 closed this in aac0466 Nov 25, 2021
Copy link

yyx990803 commented Nov 25, 2021

Thanks for the PR! The OTHER flag serves as a fallthrough value (in the switch check) so that we can skip the checks for future access, so it still needs to be there. I landed a more conservative fix in aac0466.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants