Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): Ensure custom Elements can inherit provides from ancestors (fix: #5096) #5098

Merged
merged 1 commit into from Nov 11, 2022

Conversation

LinusBorg
Copy link
Member

Without this patch, components in custom element mode would only be able to inherit provides from the first ancestor instance, anything provided further up the tree would not be available.

This PR ensures that each instance inherits its ancestors provides, ensureing any descendants have access to all provides.

fix: #5096

@LinusBorg LinusBorg added feat: custom elements 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Dec 13, 2021
@LinusBorg LinusBorg added this to In Review in Next Patch Mar 10, 2022
@LinusBorg LinusBorg moved this from In Review to Planned, might need fresh review in Next Patch Mar 10, 2022
@LinusBorg LinusBorg moved this from Planned, might need fresh review to In Review in Next Patch Mar 11, 2022
@LinusBorg LinusBorg added this to Ready to Merge in Custom Elements Bugsquash Jun 25, 2022
@LinusBorg LinusBorg moved this from Ready to Merge to PRs in Custom Elements Bugsquash Jun 25, 2022
@LinusBorg LinusBorg moved this from PRs to Ready to Merge in Custom Elements Bugsquash Jun 25, 2022
@yyx990803 yyx990803 merged commit 192dcb6 into main Nov 11, 2022
6 checks passed
Next Patch automation moved this from Open for Review to Done Nov 11, 2022
@yyx990803 yyx990803 deleted the linusborg/fix-ce-provides-inheritance branch November 11, 2022 02:33
Custom Elements Bugsquash automation moved this from Ready to Merge to Done Nov 11, 2022
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: custom elements 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Development

Successfully merging this pull request may close these issues.

Provide / Inject issues with custom elements and inserting raw html
2 participants