Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): ensure readonly refs can be replaced with new refs in reactive objects That was the behavior before 171f5e9 (fix #5307) #5310

Merged
merged 1 commit into from Jan 23, 2022

Conversation

LinusBorg
Copy link
Member

in 171f5e9 we fixed a bug concerning reactive objects allowing to write to nested read-only refs.

That fix had the unintended side-effect of also disallowing to replace a nested (readonly) ref with a new ref.

This PR fixes that and restores the original behavior to allow refs to be replaced, but still prevents readonly refs to be written to.

fix: #5307

…n reactive objects

That was the behavior before 171f5e9
@netlify
Copy link

netlify bot commented Jan 23, 2022

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 9fe8b45

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/61ed3a033612ef0007f5e8c7

😎 Browse the preview: https://deploy-preview-5310--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Jan 23, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 9fe8b45

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/61ed3a038b88680008179654

😎 Browse the preview: https://deploy-preview-5310--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Jan 23, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 9fe8b45

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/61ed3a03c6928000070b1ee0

😎 Browse the preview: https://deploy-preview-5310--vue-sfc-playground.netlify.app/

@yyx990803 yyx990803 merged commit 4be1037 into main Jan 23, 2022
11 checks passed
@yyx990803 yyx990803 deleted the linusborg/fix-readonly-ref-replace-5307 branch Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: 'set' on proxy: trap returned falsish for property
3 participants