Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): always hydrate hosited children for HMR #5406

Merged
merged 1 commit into from Feb 12, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Feb 11, 2022

fix nuxt/framework#5405
fix nuxt/nuxt#11956

In Dev, hoisted nodes are not always "static" as developers might change it with HMR. We shouldn't skip the children's hydration.

Not sure if tests are required in this case

@antfu antfu added p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. feat: hmr feat: ssr labels Feb 11, 2022
@antfu antfu changed the title fix(ssr): always hydrate children for HMR fix(runtime-core): always hydrate children for HMR Feb 11, 2022
@antfu antfu changed the title fix(runtime-core): always hydrate children for HMR fix(runtime-core): always hydrate hosited children for HMR Feb 11, 2022
@netlify
Copy link

netlify bot commented Feb 11, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: f1a6a32

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/620625b77502d40007195c7e

😎 Browse the preview: https://deploy-preview-5406--vue-next-template-explorer.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. feat: hmr feat: ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR (with Vite) randomly skip updates and stop working
2 participants