Skip to content

feat(sfc-playground): add ability to disable automatic url generation #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat(sfc-playground): add ability to disable automatic url generation #5470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd6fce4
feat(sfc-playground): add ability to disable automatic url generation
niroula-kushal Feb 22, 2022
e68acc5
Merge branch 'main' into feat/disable-auto-url-generation-5192
niroula-kushal Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/sfc-playground/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ const sfcOptions = {
}
}

// persist state
const autoUrl = ref(true);
watchEffect(() => {
if(!autoUrl.value) return;
const newHash = store
.serialize()
.replace(/^#/, useSSRMode.value ? `#__SSR__` : `#`)
Expand All @@ -68,6 +69,7 @@ function toggleSSR() {
:ssr="useSSRMode"
@toggle-dev="toggleDevMode"
@toggle-ssr="toggleSSR"
v-model:auto-url="autoUrl"
/>
<Repl
@keydown.ctrl.s.prevent
Expand Down
27 changes: 24 additions & 3 deletions packages/sfc-playground/src/Header.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,27 @@
<script setup lang="ts">
import { downloadProject } from './download/download'
import { ref, onMounted } from 'vue'
import { ref, onMounted, defineEmits, computed } from 'vue'
import Sun from './icons/Sun.vue'
import Moon from './icons/Moon.vue'
import Share from './icons/Share.vue'
import Download from './icons/Download.vue'
import GitHub from './icons/GitHub.vue'

// @ts-ignore
const props = defineProps(['store', 'dev', 'ssr'])
const { store } = props
const props = defineProps(['store', 'dev', 'ssr', 'autoUrl'])
const { store, autoUrl } = props
const emit = defineEmits(['update:autoUrl']);

const currentCommit = __COMMIT__
const activeVersion = ref(`@${currentCommit}`)
const publishedVersions = ref<string[]>()
const expanded = ref(false)

const autoUrlRef = computed({
get: () => autoUrl,
set: value => emit("update:autoUrl", value)
});

async function toggle() {
expanded.value = !expanded.value
if (!publishedVersions.value) {
Expand Down Expand Up @@ -97,6 +103,10 @@ async function fetchVersions(): Promise<string[]> {
<span>Vue SFC Playground</span>
</h1>
<div class="links">
<div class="url-generation">
<input type="checkbox" v-model="autoUrlRef" id="auto-url">
<label for="auto-url">Auto URL</label>
</div>
<div class="version" @click.stop>
<span class="active-version" @click="toggle">
Version
Expand Down Expand Up @@ -347,4 +357,15 @@ h1 img {
.links > * + * {
margin-left: 4px;
}

.url-generation {
display: flex;
flex-direction: row;
margin: 0 2px;
align-items: center;
gap: 2px;
border-right: 2px solid var(--border);
padding: 5px;
user-select: none;
}
</style>