Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow opting out from events timestamp check (fix #2513, #3933) #5474

Conversation

semiaddict
Copy link

This PR introduces a new app config: skipEventsTimestampCheck.
This boolean config option allows opting out from the events timestamp check.
The timestamp check seems to have been introduced in 360a10f to fix rare edge cases, but it also introduces new bugs that prevent some events from firing when mounting components in iframes (see #2513) or new browser windows (see #3933).

The introduced bug can render an application unusable, as many events won't fire; only those who pass the timestamp check do.

This PR does not introduce any breaking changes and sets the new config option to false by default for backward compatibility.

Closes #2513 #3933

@netlify
Copy link

netlify bot commented Feb 23, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 4d314d1
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/627abdf13267ad00099a99ec
😎 Deploy Preview https://deploy-preview-5474--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 23, 2022

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit a8052a4
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6311a6b4e235ff0008366147

@netlify
Copy link

netlify bot commented Feb 23, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 4d314d1
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/627abdf1f81bc8000838bb19
😎 Deploy Preview https://deploy-preview-5474--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Hyperblaster
Copy link

Any chance we can actually get this merged?

@raphaelmenges
Copy link

raphaelmenges commented Sep 9, 2022

I would also highly appreciate a merge!

@yyx990803 yyx990803 closed this in 5ee4053 Oct 14, 2022
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3 does not work well with iframes
3 participants