Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): Check if the type modifier in the import statement #5498

Merged
merged 1 commit into from Apr 14, 2022

Conversation

zhmushan
Copy link
Contributor

@zhmushan zhmushan commented Mar 1, 2022

If not, an exception will be thrown once the type is used in the template.

@netlify
Copy link

netlify bot commented Mar 1, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 0b9b7fa
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6256a4fe30cb430009238edc
😎 Deploy Preview https://deploy-preview-5498--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 1, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 0b9b7fa
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6256a4fecc769900080e1315
😎 Deploy Preview https://deploy-preview-5498--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 1, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 0b9b7fa
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/6256a4fe0f0f2700085815ea
😎 Deploy Preview https://deploy-preview-5498--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LinusBorg LinusBorg added feat: compiler 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Mar 10, 2022
@LinusBorg LinusBorg added this to Planned, might need fresh review in Next Patch Mar 10, 2022
@LinusBorg LinusBorg moved this from Planned, might need fresh review to In Review in Next Patch Mar 10, 2022
packages/compiler-sfc/src/compileScript.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@yyx990803 yyx990803 merged commit 8e29ef6 into vuejs:main Apr 14, 2022
8 checks passed
Next Patch automation moved this from Open for Review to Done Apr 14, 2022
@zhmushan zhmushan deleted the importtype branch April 14, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: compiler 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants