Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): fix event listener as dynamicProp is added erroneously to props #5517

Merged
merged 2 commits into from Apr 12, 2022

Conversation

iwusong
Copy link
Contributor

@iwusong iwusong commented Mar 4, 2022

when event listener as dynamicProp on updateProps, it is added to the instance’s props and it can be implicit binded to other components again by "v-bind=$props". it maybe trigger the callback function multiple times.

close #5520

@netlify
Copy link

netlify bot commented Mar 4, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 2b896fe
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/62551e2c4d7a2c000833ed62
😎 Deploy Preview https://deploy-preview-5517--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 4, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 2b896fe
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/62551e2bcf50d00008cd8abd
😎 Deploy Preview https://deploy-preview-5517--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 4, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 2b896fe
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/62551e2b0ca58d000900cd01
😎 Deploy Preview https://deploy-preview-5517--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LinusBorg
Copy link
Member

A real reproduction would be helpful for us, without having to search a long thread.

So far, I don't really get what problem this is supposed to be solving

@iwusong
Copy link
Contributor Author

iwusong commented Mar 4, 2022

Reproduction https://jsfiddle.net/29xnkcoz/3/

A real reproduction would be helpful for us, without having to search a long thread.

So far, I don't really get what problem this is supposed to be solving

Vue SFC Playground https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHRlbXBsYXRlPlxuICA8UGFyZW50Q29tIHYtZm9yPVwiaSBpbiBbMV1cIiA6a2V5PVwiaVwiPlxuICAgIDxDaGlsZEl0ZW0gQGNsaWNrPVwibG9nKGkpXCI+YW55Q29udGVudDwvQ2hpbGRJdGVtPlxuICA8L1BhcmVudENvbT5cbjwvdGVtcGxhdGU+XG5cbjxzY3JpcHQgc2V0dXA+XG5pbXBvcnQgUGFyZW50Q29tIGZyb20gXCIuL1BhcmVudENvbS52dWVcIjtcbmltcG9ydCBDaGlsZEl0ZW0gZnJvbSBcIi4vQ2hpbGRJdGVtLnZ1ZVwiO1xuICBcbmZ1bmN0aW9uIGxvZyhpKSB7XG4gIGNvbnNvbGUubG9nKGkpXG59XG48L3NjcmlwdD5cbiIsImltcG9ydC1tYXAuanNvbiI6IntcbiAgXCJpbXBvcnRzXCI6IHtcbiAgICBcInZ1ZVwiOiBcImh0dHBzOi8vdW5wa2cuY29tL0B2dWUvcnVudGltZS1kb21AMy4yLjMxL2Rpc3QvcnVudGltZS1kb20uZXNtLWJyb3dzZXIuanNcIlxuICB9XG59IiwiQ2hpbGRJdGVtLnZ1ZSI6Ijx0ZW1wbGF0ZT5cbiAgPGJ1dHRvbiBAY2xpY2s9XCIoZSk9PiRlbWl0KCdjbGljaycsZSlcIiBzdHlsZT1cIndpZHRoOjMwMHB4XCIgdi1iaW5kPVwiJHByb3BzXCI+Y2xpY2sgbWUgdGVzdO+8jGxvb2sgYXQgdGhlIGNvbnNvbGU8L2J1dHRvbj5cbjwvdGVtcGxhdGU+XG48c2NyaXB0PlxuZXhwb3J0IGRlZmF1bHQge1xuICBuYW1lOiAnQ2hpbGRJdGVtJyxcbiAgaW5oZXJpdEF0dHJzOiBmYWxzZSxcbiAgcHJvcHM6IHt9LFxuICBlbWl0czogWydjbGljayddLFxufVxuPC9zY3JpcHQ+XG4iLCJQYXJlbnRDb20udnVlIjoiPHRlbXBsYXRlPlxuICA8ZGl2PlxuICAgIHt7IGNoYW5nZSB9fVxuICA8L2Rpdj5cbiAgPGRpdj5cbiAgICA8c2xvdD48L3Nsb3Q+XG4gIDwvZGl2PlxuPC90ZW1wbGF0ZT5cbjxzY3JpcHQ+XG5leHBvcnQgZGVmYXVsdCB7XG4gIG5hbWU6IFwiUGFyZW50Q29tXCIsXG4gIGRhdGEoKSB7XG4gICAgcmV0dXJuIHtcbiAgICAgIGNoYW5nZTogXCJiZWZvcmUgdXBkYXRlLGNsaWNrIHRyaWdnZXIgb25jZVwiXG4gICAgfVxuICB9LFxuICBtb3VudGVkKCkge1xuICAgIHNldFRpbWVvdXQoKCkgPT4ge1xuICAgICAgdGhpcy5jaGFuZ2UgPSBcImFmdGVyIHVwZGF0ZSxjbGljayB0cmlnZ2VyIHR3aWNlXCI7XG4gICAgfSwgNjAwMCk7XG4gIH1cblxufTtcbjwvc2NyaXB0PlxuIn0=

@iwusong iwusong changed the title fix(runtime-core): fix event listener as dynamicProp is added to props fix(runtime-core): fix event listener as dynamicProp is added erroneously to props Mar 4, 2022
@LinusBorg LinusBorg added the p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. label Mar 10, 2022
@LinusBorg LinusBorg added this to In Review in Next Patch Mar 10, 2022
@LinusBorg LinusBorg moved this from Open for Review to High Priority in Next Patch Apr 10, 2022
@yyx990803 yyx990803 merged commit 8eceabd into vuejs:main Apr 12, 2022
8 checks passed
Next Patch automation moved this from High Priority to Done Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
Projects
Development

Successfully merging this pull request may close these issues.

event listener as dynamicProp is added erroneously to instance's props
3 participants