Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): ensure that errors in slot function execution do not affect block tracking (fix #5657) #5670

Merged
merged 3 commits into from Oct 14, 2022

Conversation

javastation
Copy link
Contributor

fix #5657
ensure that errors in slot function execution do not affect block tracking, and then affect dynamic children and patch

@netlify
Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 83b463b
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/624d4a82a7167a0008ecb39c
😎 Deploy Preview https://deploy-preview-5670--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 83b463b
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/624d4a82491dfd00098f6f46
😎 Deploy Preview https://deploy-preview-5670--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 83b463b
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/624d4a8270b2e60008029256
😎 Deploy Preview https://deploy-preview-5670--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@javastation javastation changed the title fix(runtime-core):ensure that errors in slot function execution do not affect block tracing fix(#5657) fix(runtime-core):ensure that errors in slot function execution do not affect block tracing (fix #5657) Apr 6, 2022
@javastation javastation changed the title fix(runtime-core):ensure that errors in slot function execution do not affect block tracing (fix #5657) fix(runtime-core):ensure that errors in slot function execution do not affect block tracking (fix #5657) Apr 6, 2022
@mattelen
Copy link

How far away do you think this PR will be ready for review @javastation? I am quite keen to have this as I believe this will fix an issue I have

@javastation
Copy link
Contributor Author

hi @edison1105, it seems that quite a few people have encountered this problem and I hope you can help review this pr. Thanks for your suggestions on my previous pr.

@javastation
Copy link
Contributor Author

How far away do you think this PR will be ready for review @javastation? I am quite keen to have this as I believe this will fix an issue I have

Tried my best, wait a little longer.

@flashingcursor
Copy link

Watching and waiting...

@bapaynter
Copy link

Any updates on this?

1 similar comment
@ealldy
Copy link

ealldy commented Sep 21, 2022

Any updates on this?

@antfu antfu changed the title fix(runtime-core):ensure that errors in slot function execution do not affect block tracking (fix #5657) fix(runtime-core): ensure that errors in slot function execution do not affect block tracking (fix #5657) Oct 10, 2022
antfu
antfu approved these changes Oct 10, 2022
@antfu antfu added p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. labels Oct 10, 2022
@yyx990803 yyx990803 merged commit 82a73da into vuejs:main Oct 14, 2022
9 checks passed
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'insertBefore')
8 participants