feat(ssr): improve ssr hydration mismatch checks - #5953
Merged
Conversation
- Include the actual element in the warning message - Also warn class/style/attribute mismatches Note: class/style/attribute mismatches are check-only and will not be rectified. close #5063
yyx990803
force-pushed
the
ssr-mismatch-check
branch
from
December 8, 2023 07:41
5ad12ab to
0f5b592
Compare
yyx990803
added a commit
that referenced
this pull request
Dec 12, 2023
…ings this was swapped in #9098 but lost when merging #5953
This was referenced Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: class/style/attribute mismatches are check-only and will not be rectified. This is because the performance overhead of checking and rectifying all props in production will be prohibitively expensive.
The check could potentially lead to false positives so we need to test this in a beta.
close #5063