Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-ssr): ensure app can be unmounted when created with createSSRApp() (fix #5990) #5992

merged 1 commit into from May 24, 2022


Copy link

@LinusBorg LinusBorg commented May 24, 2022

app.unmount() fails in a hydrated app because unlike render(), hydrate() doesn't cache cache the root vnode on the container element.

This PR fixes that, so that app.unmount() runs correctly for hydrated apps as well.

close: #5990

@yyx990803 yyx990803 merged commit d4d3319 into main May 24, 2022
13 checks passed
@yyx990803 yyx990803 deleted the linusborg/createssrapp-unmount-fix-5990 branch May 24, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

App created with 'createSSRApp()' on the client side is not unmounted when call 'app.unmount()' method.
2 participants