fix(runtime-core): in operator returning false for built-in instance properties in exposeProxy (fix #6137)
#6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce properties in `exposeProxy` `exposeProxy` implements a fallback logic for accessing built-in instance properties but was missing the same logic for the `in` operator in the Proxy's `has()` handler. fix vuejs#6137
7 tasks
LinusBorg
requested changes
Jul 4, 2022
LinusBorg
approved these changes
Jul 4, 2022
|
Hey, just wanted to ask if there is anything I can do to get this fix merged |
|
@yyx990803 sorry for tagging. This is my last attempt to try to get this fix merged. |
|
We are just starting an effort to clean up and re-review PRs that are unmerged even though ready to go. We have accumulated quite a number of those so it may still take a bit. Please be a bit more patient. Thanks |
antfu
approved these changes
Oct 10, 2022
sxzz
approved these changes
Oct 10, 2022
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
…nce properties in `exposeProxy` (vuejs#6138) fix vuejs#6137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR tries to fix #6137.
Background info
The component
exposeProxyimplements a fallback logic for accessing built-in instance properties but was missing the same logic for theinoperator in the Proxy'shas()handler.