fix(runtime-dom): ensure customElement handles empty props correctly. (fix #6361,#6895) #6182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusBorg
added
edison1105
approved these changes
Jun 25, 2022
LinusBorg
added
LinusBorg
changed the title
LinusBorg
force-pushed
the
linusborg/custom-element-handle-empty-props-6163
branch
from
e527c8c
to
6d677d0
Compare
|
@antfu small ping? |
antfu
approved these changes
Nov 1, 2022
LinusBorg
deleted the
linusborg/custom-element-handle-empty-props-6163
branch
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
…vuejs#6182) fix Scoped attribute in Vue file affects the use of web component vuejs#6163,vuejs#6895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If a component wrapped with
defineCustomElement()did not hae any props defined, and was passed any custom attribute (such as, in #6361, a data-v attribute), it would throw an error.closes #6163, close #6895