Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): do not throw on unknown directives #6671

Merged
merged 1 commit into from Nov 8, 2022

Conversation

cexbrayat
Copy link
Member

Fixes #6340

This commit improves the case when a directive is not found in a template. As resolveDirective returns undefined, some code was failing with the following error:

TypeError: Cannot read properties of undefined (reading 'deep')

Fixes vuejs#6340

This commit improves the case when a directive is not found in a template.
As `resolveDirective` returns `undefined`, some code was failing with the following error:

```
TypeError: Cannot read properties of undefined (reading 'deep')
```
@cexbrayat cexbrayat force-pushed the fix/6340-unknown-directive branch from 07b3269 to de2c733 Compare Oct 6, 2022
sxzz
sxzz approved these changes Oct 6, 2022
antfu
antfu approved these changes Oct 7, 2022
@yyx990803 yyx990803 merged commit 0455378 into vuejs:main Nov 8, 2022
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unresolved global directive leads to the Cannot read properties of undefined (reading 'deep') error
4 participants