Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sfc-compiler): fix duplicated declarations of macros #6778

Merged
merged 1 commit into from Nov 8, 2022
Merged

fix(sfc-compiler): fix duplicated declarations of macros #6778

merged 1 commit into from Nov 8, 2022

Conversation

shengxinjing
Copy link
Contributor

@shengxinjing shengxinjing commented Sep 29, 2022 •
edited

@antfu antfu changed the title fix: defineProps/defineEmits removal in multi-variable declaration fi… fix(sfc-compiler): fix duplicated declarations of macros Oct 3, 2022
@antfu antfu added the ready to merge The PR is ready to be merged. label Oct 3, 2022
@yyx990803 yyx990803 merged commit 99b6697 into vuejs:main Nov 8, 2022
9 checks passed
@shengxinjing shengxinjing deleted the fix6757 branch November 8, 2022 03:29
@sxzz sxzz mentioned this pull request Nov 18, 2022
Open
13 tasks
This was referenced Dec 28, 2022
Closed
Merged
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@shengxinjing @chrislone
fix(compiler-sfc): fix macro usage in multi-variable declaration (vue…
81c7064 
…js#6778)

fix vuejs#6757
@RicardoErii RicardoErii mentioned this pull request Mar 1, 2023
Open
yyx990803 pushed a commit that referenced this pull request Mar 28, 2023
@sxzz
fix(compiler-sfc): properly remove comma of multiple macros in the sa…
336a3d7 
…me declaration (#7423)

closes #7422
reverts #6778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation failed. 使用逗号定义时编译错误
3 participants
@shengxinjing @antfu @yyx990803