Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): use cleanupBuffer instead of modifying _buffer #6812

Merged
merged 3 commits into from Oct 3, 2022

Conversation

posva
Copy link
Member

@posva posva commented Oct 3, 2022

At the moment the Playground SFC is broken when devtools are installed. I noticed _buffer is not always present so I adapted the type but maybe this isn't the right fix
cc @Akryum

@posva posva added p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. sfc-playground labels Oct 3, 2022
antfu
antfu approved these changes Oct 3, 2022
@Akryum
Copy link
Member

Akryum commented Oct 3, 2022

In iframes the hook object is different: https://github.com/vuejs/devtools/blob/8dd0ef228a6c6a3913082b0fc2f34bffb777f6fc/packages/app-backend-core/src/hook.ts#L78-L105

packages/runtime-core/src/devtools.ts Outdated Show resolved Hide resolved
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@Akryum
Copy link
Member

Akryum commented Oct 3, 2022

vuejs/devtools@f2ad51e

Akryum
Akryum approved these changes Oct 3, 2022
@Akryum Akryum changed the title fix(devtools): check _buffer existance fix(devtools): use cleanupBuffer instead of modifying _buffer Oct 3, 2022
@Akryum Akryum merged commit 35a113e into main Oct 3, 2022
13 checks passed
@Akryum Akryum deleted the fix/devtools branch Oct 3, 2022
@segevfiner
Copy link

@posva @Akryum We hit a serious performance issue in dev mode in Vue v3.2.41 vs v3.2.40 which forced us to pin our version and we suspect it was caused by this PR as the performance tools point to cleanupBuffer. This is on a page which mounts/unmounts components rather rapidly, when I have the time I'll try to create a reproduction and report separately.

@matej-svejda
Copy link

matej-svejda commented Jan 10, 2023

@posva @Akryum We hit a serious performance issue in dev mode in Vue v3.2.41 vs v3.2.40 which forced us to pin our version and we suspect it was caused by this PR as the performance tools point to cleanupBuffer. This is on a page which mounts/unmounts components rather rapidly, when I have the time I'll try to create a reproduction and report separately.

We ran into the same issue. Unmounting of components in dev mode when devtools is installed is significantly slower (if I would have to guess by a factor of 10). Uninstalling devtools resolves that.

@Akryum
Copy link
Member

Akryum commented Jan 10, 2023

This performance issue should hopefully be fixed by vuejs/devtools@60aeed2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. sfc-playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants