Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity-transform): don't overwrite scope and user imports #6840

Merged

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Oct 9, 2022

closes #6838


Fixed cases:

@sxzz sxzz force-pushed the fix/reactivity-transform-existing-variable branch from 34b6e3f to be46a2c Compare Oct 9, 2022
// default symbol
if (!convertSymbol && !userImports[CONVERT_SYMBOL]) {
convertSymbol = CONVERT_SYMBOL
}
if (!escapeSymbol && !userImports[ESCAPE_SYMBOL]) {
escapeSymbol = ESCAPE_SYMBOL
}
Copy link
Member Author

@sxzz sxzz Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some opinions about the RFC: vuejs/rfcs#369 (comment)

antfu
antfu approved these changes Oct 10, 2022
@sxzz sxzz force-pushed the fix/reactivity-transform-existing-variable branch 2 times, most recently from 7bc7011 to 0b8f9ef Compare Nov 1, 2022
@sxzz sxzz force-pushed the fix/reactivity-transform-existing-variable branch from 0b8f9ef to 1eef344 Compare Nov 8, 2022
@yyx990803 yyx990803 merged commit 7663a79 into vuejs:main Nov 9, 2022
9 checks passed
@sxzz sxzz deleted the fix/reactivity-transform-existing-variable branch Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When enable reactivityTransform $ can only be used as the initializer of a variable declaration. appears
3 participants