Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity-transform): respect const keyword #6993

Merged
merged 4 commits into from Nov 14, 2022
Merged

fix(reactivity-transform): respect const keyword #6993

merged 4 commits into from Nov 14, 2022

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Oct 30, 2022

closes #6992

@sxzz sxzz force-pushed the fix/reactivity-transform-const branch from b661465 to 426a9a6 Compare October 30, 2022 14:28
@netlify
Copy link

netlify bot commented Oct 30, 2022 •
edited

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 23447d9
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/636cd0b7d7b718000924fcc8

@sxzz sxzz force-pushed the fix/reactivity-transform-const branch 3 times, most recently from d7a2056 to 49e1ac6 Compare October 30, 2022 14:57
@sxzz sxzz marked this pull request as ready for review October 30, 2022 15:00
@sxzz sxzz requested a review from yyx990803 October 30, 2022 15:00
@sxzz sxzz force-pushed the fix/reactivity-transform-const branch 2 times, most recently from bb865de to 5685c1a Compare November 8, 2022 10:36
@sxzz sxzz requested a review from antfu November 8, 2022 14:31
@sxzz sxzz force-pushed the fix/reactivity-transform-const branch 8 times, most recently from 69fd331 to 279e051 Compare November 11, 2022 12:22
@sxzz sxzz force-pushed the fix/reactivity-transform-const branch from 279e051 to e033f42 Compare November 14, 2022 00:50
@netlify
Copy link

netlify bot commented Nov 14, 2022

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit c5ef3b6
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6371f33695f012000aa63e9e

@yyx990803 yyx990803 merged commit 3427052 into vuejs:main Nov 14, 2022
4 of 9 checks passed
@sxzz sxzz deleted the fix/reactivity-transform-const branch November 14, 2022 07:55
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@sxzz @chrislone
fix(reactivity-transform): prohibit const assignment at compile time (v…
1131f12 
…uejs#6993)

close vuejs#6992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 left review comments

@antfu antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reactivity Transform should respect const keyword
2 participants
@sxzz @yyx990803