Skip to content

fix(server-renderer): render components returning render function from setup #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yyx990803 merged 2 commits into from
Feb 15, 2020
Merged

fix(server-renderer): render components returning render function from setup #720

yyx990803 merged 2 commits into from
Feb 15, 2020

Conversation

@dsseng
Copy link
Contributor

@dsseng dsseng commented Feb 13, 2020

Component setup utils update instance but server-renderer expects render function to be on component options object.

yyx990803
yyx990803 requested changes Feb 13, 2020
View reviewed changes
@dsseng dsseng requested a review from yyx990803 February 13, 2020 17:15
@dsseng dsseng mentioned this pull request Feb 15, 2020
Merged
@yyx990803 yyx990803 merged commit 4669215 into vuejs:master Feb 15, 2020
@dsseng dsseng deleted the fix/setup-render branch February 15, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsseng @yyx990803