From 1b7a4fd760e5e84d94d2b68d78e6899a73d21a5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=B8=B6=E8=BF=9C=E6=96=B9?= <yangpanteng@gmail.com>
Date: Wed, 23 Aug 2023 23:20:27 +0800
Subject: [PATCH 1/3] chore(eslint): update eslint `no-unused-vars` rules

---
 .eslintrc.cjs    | 13 +++++++------
 scripts/build.js |  2 +-
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index 04ecf049ca9..05a95fc4aff 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -9,12 +9,6 @@ module.exports = {
   plugins: ['jest'],
   rules: {
     'no-debugger': 'error',
-    'no-unused-vars': [
-      'error',
-      // we are only using this rule to check for unused arguments since TS
-      // catches unused variables but not args.
-      { varsIgnorePattern: '.*', args: 'none' }
-    ],
     // most of the codebase are expected to be env agnostic
     'no-restricted-globals': ['error', ...DOMGlobals, ...NodeGlobals],
 
@@ -72,6 +66,13 @@ module.exports = {
         'no-restricted-syntax': 'off'
       }
     },
+    // JavaScript files
+    {
+      files: ['*.js'],
+      rules: {
+        'no-unused-vars': ['error', { vars: 'all', args: 'none' }]
+      }
+    },
     // Node scripts
     {
       files: ['scripts/**', '*.{js,ts}', 'packages/**/index.js'],
diff --git a/scripts/build.js b/scripts/build.js
index 1f8af65017d..d96dd8a0984 100644
--- a/scripts/build.js
+++ b/scripts/build.js
@@ -17,7 +17,7 @@ nr build core --formats cjs
 */
 
 import fs from 'node:fs/promises'
-import { existsSync, readFileSync } from 'node:fs'
+import { existsSync } from 'node:fs'
 import path from 'node:path'
 import minimist from 'minimist'
 import { gzipSync, brotliCompressSync } from 'node:zlib'

From e790c1a71fec2d19665c08ea5de56661586fbe09 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=B8=B6=E8=BF=9C=E6=96=B9?= <yangpanteng@gmail.com>
Date: Wed, 23 Aug 2023 23:58:27 +0800
Subject: [PATCH 2/3] chore: added comment

---
 .eslintrc.cjs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index 05a95fc4aff..cc89e245d04 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -70,6 +70,7 @@ module.exports = {
     {
       files: ['*.js'],
       rules: {
+        // We only do `no-unused-vars` checks for js files, TS files are checked by TypeScript itself.
         'no-unused-vars': ['error', { vars: 'all', args: 'none' }]
       }
     },

From 6b9f6f61eba0041c64bc826ea4d46d7f38a1c487 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=B8=89=E5=92=B2=E6=99=BA=E5=AD=90=20Kevin=20Deng?=
 <sxzz@sxzz.moe>
Date: Sun, 3 Sep 2023 00:36:32 +0800
Subject: [PATCH 3/3] chore: add cjs

---
 .eslintrc.cjs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index cc89e245d04..4296d0f39b6 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -1,3 +1,5 @@
+/* eslint-disable no-restricted-globals */
+
 const DOMGlobals = ['window', 'document']
 const NodeGlobals = ['module', 'require']
 
@@ -68,7 +70,7 @@ module.exports = {
     },
     // JavaScript files
     {
-      files: ['*.js'],
+      files: ['*.js', '*.cjs'],
       rules: {
         // We only do `no-unused-vars` checks for js files, TS files are checked by TypeScript itself.
         'no-unused-vars': ['error', { vars: 'all', args: 'none' }]