Skip to content

docs: Correct typing & fix edit document links #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2023
Merged

docs: Correct typing & fix edit document links #1981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06c6de4
docs: correct typing
ThinhVu Nov 5, 2022
98f1f1d
docs: update repo name
ThinhVu Nov 5, 2022
1c206e5
fix(docs): update repo name, docsDir
ThinhVu Nov 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/docs/src/.vitepress/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ export default defineConfig({
],

themeConfig: {
repo: 'vuejs/vue-devtools',
repo: 'vuejs/devtools',
logo: '/logo-header.svg',
docsDir: 'docs',
docsDir: 'packages/docs/src',
docsBranch: 'main',
editLinks: true,
editLinkText: 'Suggest changes to this page',
Expand Down
8 changes: 4 additions & 4 deletions packages/docs/src/guide/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ Thank you for your code contribution! Before opening a PR, please make sure to r
This is useful when you want to build the extension with the source repo to get not-yet-released features.

1. Clone this repo
2. `cd vue-devtools` the newly created folder
2. `cd devtools` the newly created folder
3. run `yarn install`
4. then run `yarn run build:watch` & `yarn run dev:chrome` in parallel
5. Open the Chrome extension page (currently under `Menu` > `More Tools` > `Extensions`)
6. Check "developer mode" on the top-right corner
7. Click the "load unpacked" button on the left, and choose the folder: `vue-devtools/packages/shell-chrome/` (it will have an orange disk icon)
7. Click the "load unpacked" button on the left, and choose the folder: `devtools/packages/shell-chrome/` (it will have an orange disk icon)
8. Make sure you disable all other versions of the extension

## Testing as Firefox addon
Expand All @@ -94,6 +94,6 @@ This is useful when you want to build the extension with the source repo to get
## Docs development

1. Clone this repo
2. `cd vue-devtools` the newly created folder
2. `cd devtools` the newly created folder
3. run `yarn install`
4. run `docs:dev`
4. run `docs:dev`
2 changes: 1 addition & 1 deletion packages/docs/src/guide/devtools-perf.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Make sure you have run both the `build:watch` and the `dev:vue3` scripts as [exp

In the Chrome window, open the devtools development shell at `http://localhost:8090`.

You can shen change the target URL in the toolbar on top of the devtools:
You can then change the target URL in the toolbar on top of the devtools:

![devtools shell screenshot](../assets/dev-shell-url.png)

Expand Down