Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue/valid-next-tick rule #1404

Merged
merged 11 commits into from Jan 21, 2021
Merged

Add vue/valid-next-tick rule #1404

merged 11 commits into from Jan 21, 2021

Conversation

@FloEdelmann
Copy link
Contributor

@FloEdelmann FloEdelmann commented Jan 2, 2021

Closes #1399.

Copy link
Member

@ota-meshi ota-meshi left a comment

Thank you for your contribution! I have some requests.

lib/rules/valid-next-tick.js Outdated Show resolved Hide resolved
lib/rules/valid-next-tick.js Show resolved Hide resolved
lib/rules/valid-next-tick.js Outdated Show resolved Hide resolved
lib/rules/valid-next-tick.js Outdated Show resolved Hide resolved
lib/rules/valid-next-tick.js Show resolved Hide resolved
@FloEdelmann FloEdelmann requested a review from ota-meshi Jan 4, 2021
Copy link
Member

@ota-meshi ota-meshi left a comment

Sorry for late reply. Thank you for changing. LGTM!

@ota-meshi ota-meshi merged commit 10824ec into vuejs:master Jan 21, 2021
10 checks passed
@FloEdelmann FloEdelmann deleted the valid-next-tick branch Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants