Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove mention of "prettier/vue" #1449

Merged
merged 3 commits into from Mar 3, 2021
Merged

docs: remove mention of "prettier/vue" #1449

merged 3 commits into from Mar 3, 2021

Conversation

@thorn0
Copy link
Contributor

@thorn0 thorn0 commented Mar 2, 2021

prettier/vue, prettier/@typescript-eslint, etc. have been removed in eslint-config-prettier v8.0.0.
They are needed no longer.
See https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21

I've also removed the "If [Prettier] conflicts with the rule you have set, turn off that rule" part because that's exactly what eslint-config-prettier is for.

`prettier/vue`, `prettier/@typescript-eslint`, etc. have been removed in `eslint-config-prettier` v8.0.0.
They are needed no longer.
See https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21

I've also removed the "If [Prettier] conflicts with the rule you have set, turn off that rule" part because that's exactly what `eslint-config-prettier` is for.
@ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Mar 3, 2021

Thank you for this PR.

I've also removed the "If [Prettier] conflicts with the rule you have set, turn off that rule" part because that's exactly what eslint-config-prettier is for.

I think this explanation is necessary because users can override the rules by adding them to rules.
What do you think?

@thorn0
Copy link
Contributor Author

@thorn0 thorn0 commented Mar 3, 2021

@ota-meshi Good point. Fixed.

Copy link
Member

@ota-meshi ota-meshi left a comment

Thank you!

@ota-meshi ota-meshi merged commit db2928a into vuejs:master Mar 3, 2021
10 checks passed
10 checks passed
@netlify
Header rules No header rules processed
Details
@netlify
Pages changed 202 new files uploaded
Details
@netlify
Redirect rules No redirect rules processed
Details
@netlify
Mixed content No mixed content detected
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: node-v10 Your tests passed on CircleCI!
Details
ci/circleci: node-v12 Your tests passed on CircleCI!
Details
ci/circleci: node-v14 Your tests passed on CircleCI!
Details
ci/circleci: node-v8 Your tests passed on CircleCI!
Details
@netlify
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants