Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue/no-reserved-props rule #1678

Merged
merged 2 commits into from Oct 29, 2021
Merged

Add vue/no-reserved-props rule #1678

merged 2 commits into from Oct 29, 2021

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Oct 27, 2021

This PR adds vue/no-reserved-props rule that disallow reserved names to be used in props.
Also, add new vue/no-reserved-props rule to the essential and vue3-essential rulesets.

close #1676

3: ['key', 'ref'],
2: ['key', 'ref', 'is', 'slot', 'slot-scope', 'slotScope']
Copy link
Member

@FloEdelmann FloEdelmann Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should class and style also be added?

Copy link
Member Author

@ota-meshi ota-meshi Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for telling me that! I didn't check those two props. They are not available in Vue2. I need to add check.

@ota-meshi ota-meshi merged commit 0aeaaaf into master Oct 29, 2021
12 checks passed
@ota-meshi ota-meshi deleted the no-reserved-props branch Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Proposal: no-ref-prop
2 participants