Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add setup-compiler-macros environment #1685

Merged
merged 1 commit into from Oct 28, 2021

Conversation

foxxyz
Copy link
Contributor

@foxxyz foxxyz commented Oct 28, 2021

Adds a setup-compiler-macros environment which allows users to enable the globals used in <script setup> and prevent no-undef warnings per #1662.

Use via:

module.exports = {
  env: {
    'vue/setup-compiler-macros': true
  }
}

Modifies docs to illustrate correct usage.

Let me know if this is an acceptable approach, and if you'd like me to make additional changes!

Closes #1662

Copy link
Member

@ota-meshi ota-meshi left a comment

Thank you for this PR!
I made one comment.

docs/user-guide/README.md Show resolved Hide resolved
@foxxyz foxxyz force-pushed the vue3-compiler-macros-env branch 2 times, most recently from f37c63c to 35e8a0c Compare Oct 28, 2021
@foxxyz foxxyz force-pushed the vue3-compiler-macros-env branch from 35e8a0c to 89f2c9a Compare Oct 28, 2021
Copy link
Member

@ota-meshi ota-meshi left a comment

LGTM! Thank you very much!

@ota-meshi ota-meshi merged commit 44ff0e0 into vuejs:master Oct 28, 2021
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: setup compiler macros environment
2 participants