Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue/no-undef-components rule and deprecate vue/no-unregistered-components rule #1763

Merged
merged 7 commits into from Jan 19, 2022

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Jan 19, 2022

This PR adds vue/no-undef-components rule and deprecates vue/no-unregistered-components rule .
The vue/no-undef-components rule warns that the component used in the <template> is not defined.

close #1693

@ota-meshi ota-meshi requested a review from FloEdelmann Jan 19, 2022
@ota-meshi ota-meshi changed the title Add vue/no-undef-components-in-script-setup rule Add vue/no-undef-components rule and deprecate vue/no-unregistered-components rule Jan 19, 2022
@ota-meshi
Copy link
Member Author

@ota-meshi ota-meshi commented Jan 19, 2022

I changed this PR. So please check again.

@ota-meshi ota-meshi requested a review from FloEdelmann Jan 19, 2022
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Looks good to me. Just a docs wording suggestion.

docs/rules/no-undef-components.md Outdated Show resolved Hide resolved
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
@ota-meshi ota-meshi merged commit ee1e1e5 into master Jan 19, 2022
12 checks passed
@ota-meshi ota-meshi deleted the no-undef-components-script-setup branch Jan 19, 2022
@@ -44,8 +44,10 @@ module.exports = {
'disallow using components that are not registered inside templates',
categories: null,
recommended: false,
url: 'https://eslint.vuejs.org/rules/no-unregistered-components.html'
url: 'https://eslint.vuejs.org/rules/no-unregistered-components.html',
replacedBy: ['no-undef-components']
Copy link
Contributor

@privatenumber privatenumber Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this replacedBy needs to be outside of the doc object:
https://eslint.org/docs/developer-guide/working-with-rules#rule-basics

Copy link
Member

@FloEdelmann FloEdelmann Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch! I fixed the position in #1783.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants