Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive for script setup in vue/no-expose-after-await rule #1896

Merged
merged 1 commit into from May 18, 2022

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented May 18, 2022

fixes #1895

callNode.parent.type === 'ExpressionStatement' &&
callNode.parent.parent === node,
callNode.parent.parent === node &&
id.name === 'defineExpose',
Copy link
Member Author

@ota-meshi ota-meshi May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have added an id check but missed it.

@ota-meshi
Copy link
Member Author

ota-meshi commented May 18, 2022

I will merge and release this as it has a big impact.

@ota-meshi ota-meshi merged commit 5a5c6e8 into master May 18, 2022
14 checks passed
@ota-meshi ota-meshi deleted the issue1895 branch May 18, 2022
@FloEdelmann
Copy link
Member

FloEdelmann commented May 18, 2022

Retrospective approval 😉

Thanks for fixing!

@AndreasNasman
Copy link

AndreasNasman commented May 18, 2022

Same, thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants