From 6cd4acc218b3f10c4fa158a4e265ba381652d6ad Mon Sep 17 00:00:00 2001
From: Vida Xie <vida_2020@163.com>
Date: Sat, 22 Nov 2025 14:57:50 +0800
Subject: [PATCH 1/5] fix(no-multiple-template-root): skip comments outside
 `template`

---
 lib/rules/no-multiple-template-root.js       |  9 ++++-----
 lib/utils/index.js                           |  5 +++--
 tests/lib/rules/no-multiple-template-root.js | 11 ++++++++++-
 3 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/lib/rules/no-multiple-template-root.js b/lib/rules/no-multiple-template-root.js
index 524b7a2b1..1d0a270d2 100644
--- a/lib/rules/no-multiple-template-root.js
+++ b/lib/rules/no-multiple-template-root.js
@@ -14,10 +14,7 @@ const utils = require('../utils')
  */
 function getReportComments(comments, elementRanges) {
   return comments.filter(
-    (comment) =>
-      !elementRanges.some(
-        (range) => range[0] <= comment.range[0] && comment.range[1] <= range[1]
-      )
+    (comment) => !elementRanges.some((range) => utils.inRange(range, comment))
   )
 }
 
@@ -65,7 +62,9 @@ module.exports = {
           return
         }
 
-        const comments = element.comments
+        const comments = element.comments.filter((comment) =>
+          utils.inRange(comment, element)
+        )
         const elementRanges = element.children.map((child) => child.range)
         if (disallowComments && comments.length > 0) {
           for (const comment of getReportComments(comments, elementRanges)) {
diff --git a/lib/utils/index.js b/lib/utils/index.js
index dabdc2ba3..e204da794 100644
--- a/lib/utils/index.js
+++ b/lib/utils/index.js
@@ -1969,10 +1969,11 @@ module.exports = {
   },
   /**
    * Checks whether the target node is within the given range.
-   * @param { [number, number] } range
+   * @param { [number, number] | ASTNode | Token } rangeOrNode
    * @param {ASTNode | Token} target
    */
-  inRange(range, target) {
+  inRange(rangeOrNode, target) {
+    const range = Array.isArray(rangeOrNode) ? rangeOrNode : rangeOrNode.range
     return range[0] <= target.range[0] && target.range[1] <= range[1]
   },
   /**
diff --git a/tests/lib/rules/no-multiple-template-root.js b/tests/lib/rules/no-multiple-template-root.js
index 8df286804..52b601dbc 100644
--- a/tests/lib/rules/no-multiple-template-root.js
+++ b/tests/lib/rules/no-multiple-template-root.js
@@ -122,6 +122,15 @@ ruleTester.run('no-multiple-template-root', rule, {
       </template>
       `,
       options: [{ disallowComments: true }]
+    },
+    {
+      code: `
+        <!-- comment -->
+        <template>
+          <div>abc</div>
+        </template>
+        `,
+      options: [{ disallowComments: true }]
     }
   ],
   invalid: [
@@ -371,7 +380,7 @@ ruleTester.run('no-multiple-template-root', rule, {
     {
       code: `
       <template>
-        <!-- When you have a comment in the root of your template in vue 3, 
+        <!-- When you have a comment in the root of your template in vue 3,
         using $el will point to the first text comment instead of the actual DOM element.   -->
         <div>
           12333

From e6b0ad06bc9afe47f5368731c7a630bbb4612bfb Mon Sep 17 00:00:00 2001
From: Vida Xie <vida_2020@163.com>
Date: Sat, 22 Nov 2025 15:03:43 +0800
Subject: [PATCH 2/5] fix

---
 lib/rules/no-multiple-template-root.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rules/no-multiple-template-root.js b/lib/rules/no-multiple-template-root.js
index 1d0a270d2..e7456803a 100644
--- a/lib/rules/no-multiple-template-root.js
+++ b/lib/rules/no-multiple-template-root.js
@@ -63,7 +63,7 @@ module.exports = {
         }
 
         const comments = element.comments.filter((comment) =>
-          utils.inRange(comment, element)
+          utils.inRange(element, comment)
         )
         const elementRanges = element.children.map((child) => child.range)
         if (disallowComments && comments.length > 0) {

From 1543f1cb786ecd55038dcfb0ea8071f599f9696f Mon Sep 17 00:00:00 2001
From: Vida Xie <vida_2020@163.com>
Date: Sat, 22 Nov 2025 15:09:21 +0800
Subject: [PATCH 3/5] refactor: simplify code and avoid unnecessary array
 allocations

---
 lib/rules/no-multiple-template-root.js | 21 ++++++---------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/lib/rules/no-multiple-template-root.js b/lib/rules/no-multiple-template-root.js
index e7456803a..cb840c01c 100644
--- a/lib/rules/no-multiple-template-root.js
+++ b/lib/rules/no-multiple-template-root.js
@@ -6,18 +6,6 @@
 
 const utils = require('../utils')
 
-/**
- * Get all comments that need to be reported
- * @param {(HTMLComment | HTMLBogusComment | Comment)[]} comments
- * @param {Range[]} elementRanges
- * @returns {(HTMLComment | HTMLBogusComment | Comment)[]}
- */
-function getReportComments(comments, elementRanges) {
-  return comments.filter(
-    (comment) => !elementRanges.some((range) => utils.inRange(range, comment))
-  )
-}
-
 module.exports = {
   meta: {
     type: 'problem',
@@ -65,9 +53,12 @@ module.exports = {
         const comments = element.comments.filter((comment) =>
           utils.inRange(element, comment)
         )
-        const elementRanges = element.children.map((child) => child.range)
-        if (disallowComments && comments.length > 0) {
-          for (const comment of getReportComments(comments, elementRanges)) {
+        const reportComments = comments.filter(
+          (comment) =>
+            !element.children.some((child) => utils.inRange(child, comment))
+        )
+        if (disallowComments) {
+          for (const comment of reportComments) {
             context.report({
               node: comment,
               loc: comment.loc,

From 54bd4c2faf1961adddb6cc9865ef39a9ea062578 Mon Sep 17 00:00:00 2001
From: Vida Xie <vida_2020@163.com>
Date: Sat, 22 Nov 2025 15:12:33 +0800
Subject: [PATCH 4/5] perf: merge multiple `filter` calls into one

---
 lib/rules/no-multiple-template-root.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/rules/no-multiple-template-root.js b/lib/rules/no-multiple-template-root.js
index cb840c01c..2d9875ef3 100644
--- a/lib/rules/no-multiple-template-root.js
+++ b/lib/rules/no-multiple-template-root.js
@@ -50,11 +50,9 @@ module.exports = {
           return
         }
 
-        const comments = element.comments.filter((comment) =>
-          utils.inRange(element, comment)
-        )
-        const reportComments = comments.filter(
+        const reportComments = element.comments.filter(
           (comment) =>
+            utils.inRange(element, comment) &&
             !element.children.some((child) => utils.inRange(child, comment))
         )
         if (disallowComments) {

From fb6728ec6d14707e9a970b347a777d8933fb92b2 Mon Sep 17 00:00:00 2001
From: Vida Xie <vida_2020@163.com>
Date: Sat, 22 Nov 2025 22:44:16 +0800
Subject: [PATCH 5/5] test: update

---
 tests/lib/rules/no-multiple-template-root.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/lib/rules/no-multiple-template-root.js b/tests/lib/rules/no-multiple-template-root.js
index 52b601dbc..9a07204fc 100644
--- a/tests/lib/rules/no-multiple-template-root.js
+++ b/tests/lib/rules/no-multiple-template-root.js
@@ -123,13 +123,15 @@ ruleTester.run('no-multiple-template-root', rule, {
       `,
       options: [{ disallowComments: true }]
     },
+
+    // https://github.com/vuejs/eslint-plugin-vue/issues/2948
     {
       code: `
         <!-- comment -->
         <template>
           <div>abc</div>
         </template>
-        `,
+      `,
       options: [{ disallowComments: true }]
     }
   ],