typescript-vue-plugin caches getExternalFiles and hence doesnt have updated list of external files when new vue files are added

[sheetalkamat]

I was looking into microsoft/TypeScript#55525 and have fix as part of microsoft/TypeScript#55716
i have a test that seems to work but validating against the current plugin, seems to not work as expected. When i debugged it, it seems the external files are cached for the project and hence when queried about it while updating list of files for the project, it seems to get the old list and does not have newly added vue file.
f7ab51e#diff-4908c4b643b0a53f52116f73ef63e7707a880156989108a78d60e3b5a94114afR36 is the corresponding line.

[johnsoncodehk]

Thanks for letting me know! Do you suggest that instead of caching external files, we re-search for .vue files in the project on every getExternalFiles request? Do you think this could cause potential performance issues?

[sheetalkamat]

If using cache, the plugin need to be looking for addition or deletion of .vue files and on those cases you would want to search the files again from the disk and update the cache.

[johnsoncodehk]

In case I misunderstood, should we maintain our own file watchers for *.vue to update the cache?

[sheetalkamat]

Per current design, yes.

[sheetalkamat]

But we could pass parameter to getExternalFiles about what kind of update on program is happening that you could use.

[johnsoncodehk]

This will be neat, thanks! cc @mizdra, @Princesseuh

Related code:

• https://github.com/withastro/language-tools/blob/4046fb8cc6ea1c5440928aeb579da05baadd9c32/packages/ts-plugin/src/index.ts#L37-L42
• https://github.com/mizdra/typescript-plugin-asset/blob/baee482e1bc223a4238d8e868cfacfc5fdac1183/src/index.ts#L43-L45