Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change active and exact-active behavior for router-link #136

Open
wants to merge 6 commits into
base: master
from

Conversation

@posva
Copy link
Member

posva commented Feb 28, 2020

Rendered

Make active matching more consistent by avoiding existing caveats by design

  • Is this breaking change bringing more value than the old behavior?
  • Are any of the alternatives listed more desirable?
  • Do you need the exact prop?

Please, vote with 馃憤 and 馃憥 if this is something you want or not

posva added 3 commits Feb 29, 2020
@posva

This comment has been minimized.

Copy link
Member Author

posva commented Mar 4, 2020

I added a few examples about the breaking change that should make this RFC clearer

@posva

This comment has been minimized.

Copy link
Member Author

posva commented Mar 12, 2020

I added a section about aliases to explain how they behave with the active behavior

@posva

This comment has been minimized.

Copy link
Member Author

posva commented Mar 20, 2020

Added a section about nested absolute aliases

@posva

This comment has been minimized.

Copy link
Member Author

posva commented Apr 7, 2020

This RFC is now in final comments stage. An RFC in final comments stage means that:

The core team has reviewed the feedback and reached consensus about the general direction of the RFC and believe that this RFC is a worthwhile addition to the framework.
Final comments stage does not mean the RFC's design details are final - we may still tweak the details as we implement it and discover new technical insights or constraints. It may even be further adjusted based on user feedback after it lands in an alpha/beta release.
If no major objections with solid supporting arguments have been presented after a week, the RFC will be merged and become an active RFC.

@posva posva added the final comments label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.