New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide sourcemap for blocks in .vue file #215

Merged
merged 4 commits into from Jun 24, 2018

Conversation

Projects
None yet
2 participants
@znck
Copy link
Member

znck commented Jun 24, 2018

Fixes #194

znck added some commits Jun 24, 2018

@znck znck merged commit a5928ad into vuejs:master Jun 24, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@znck znck deleted the znck:feat/source-map-support branch Jun 24, 2018

@StevenLiekens

This comment has been minimized.

Copy link
Contributor

StevenLiekens commented Dec 28, 2018

@znck can you take another look at this? I think this PR causes #238 and #248

@StevenLiekens

This comment has been minimized.

Copy link
Contributor

StevenLiekens commented Dec 28, 2018

I'm no Rollup expert but if my config contains this:

    output: {
        file: 'dist/bundle.js',
        format: 'esm',
        sourcemap: false
    }

Then I wouldn't expect to find any source maps in dist/bundle.js. Yet if I do a search for "sourcesContent" then all my original .vue files are there.

(rollup-plugin-vue@4.2.0)

I think this needs a rewrite...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment