This repository was archived by the owner on Jan 18, 2022. It is now read-only.
fix: Copies SFCDescriptor before further passing it to processors #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scss processor modifies descriptor.styles[x].map.mappings and `parse` function from `component-compiler-utils` caches the parsing result. These two combined would cause a bug when rolling-up multiple-output configuration since the descriptor is modified and cached in the first turn and causing successive turns to fail.
znck
approved these changes
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scss processor modifies descriptor.styles[x].map.mappings and
parsefunction fromcomponent-compiler-utilscaches the parsingresult. These two combined would cause a bug when rolling-up
multiple-output configuration since the descriptor is modified and
cached in the first turn and causing successive turns to fail.
Fixes #241 #239 .
Changes proposed in this pull request:
/ping @znck