Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copies SFCDescriptor before further passing it to processors #243

Merged
merged 1 commit into from Nov 5, 2018

Conversation

@nandin-borjigin
Copy link

@nandin-borjigin nandin-borjigin commented Nov 5, 2018

scss processor modifies descriptor.styles[x].map.mappings and
parse function from component-compiler-utils caches the parsing
result. These two combined would cause a bug when rolling-up
multiple-output configuration since the descriptor is modified and
cached in the first turn and causing successive turns to fail.

Fixes #241 #239 .

Changes proposed in this pull request:

/ping @znck

scss processor modifies descriptor.styles[x].map.mappings and
`parse` function from `component-compiler-utils` caches the parsing
result. These two combined would cause a bug when rolling-up
multiple-output configuration since the descriptor is modified and
cached in the first turn and causing successive turns to fail.
znck
znck approved these changes Nov 5, 2018
@znck znck merged commit 3c1113b into vuejs:master Nov 5, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants